Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update conjur-env go.mod dependencies #143

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Update conjur-env go.mod dependencies #143

merged 1 commit into from
Jun 8, 2022

Conversation

andytinkham
Copy link
Contributor

Signed-off-by: Andy Tinkham andy.tinkham@cyberark.com

Desired Outcome

Update dependencies to latest versions in conjur-env/go.mod

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@andytinkham andytinkham requested a review from a team as a code owner June 8, 2022 19:56
@andytinkham andytinkham force-pushed the update-conjur-env-dependencies branch from 808d71c to a8bfb88 Compare June 8, 2022 20:06
john-odonnell
john-odonnell reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog update might need to be in a new section, but LGTM otherwise 👍

CHANGELOG.md Show resolved Hide resolved
@andytinkham andytinkham force-pushed the update-conjur-env-dependencies branch from a8bfb88 to 1e414e7 Compare June 8, 2022 21:04
@andytinkham
Update dependencies in conjur-env/go.mod
61806f3 
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
@andytinkham andytinkham force-pushed the update-conjur-env-dependencies branch from 1e414e7 to 61806f3 Compare June 8, 2022 21:08
john-odonnell
john-odonnell approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andytinkham andytinkham merged commit 8a87533 into main Jun 8, 2022
@andytinkham andytinkham deleted the update-conjur-env-dependencies branch June 8, 2022 21:51
@john-odonnell john-odonnell mentioned this pull request Jul 8, 2022
Merged
@gl-johnson gl-johnson mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-odonnell john-odonnell john-odonnell approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andytinkham @john-odonnell